[ISSUE-241] Fix Exception Type Raised in .flash()#243
Merged
Conversation
This patch fixes the wrong exception being raised in the `.flash()` function; currently is `JLinkEraseException()`, is now `JLinkFlashException()`.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect exception type being raised in the .flash() method. The function was incorrectly raising JLinkEraseException instead of the more appropriate JLinkFlashException when the flash operation fails.
- Corrects exception type from
JLinkEraseExceptiontoJLinkFlashExceptionin the flash method
| res = self._dll.JLINKARM_EndDownload() | ||
| if res < 0: | ||
| raise errors.JLinkEraseException(res) | ||
| raise errors.JLinkFlashException(res) |
There was a problem hiding this comment.
The PR title contains a spelling error: 'excpetion' should be 'exception'.
hkpeprah
changed the title
.flash().flash()
bbrown1867
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ISSUE-241] Fix Exception Type Raised in
.flash()Overview
This patch fixes the wrong exception being raised in the
.flash()function; currently isJLinkEraseException(), is nowJLinkFlashException().